Checkstyle Results

The following document contains the results of Checkstyle 6.11.2 with sun_checks.xml ruleset. 

Summary

Files	Info	Warnings	Errors
5	0	0	59

Files

File	I	W	E
info/mikethomas/fahview/viewer/JmolPanel.java	0	0	12
info/mikethomas/fahview/viewer/files/xyz/XyzFileDataObject.java	0	0	30
info/mikethomas/fahview/viewer/files/xyz/XyzFileVisualElement.java	0	0	16
info/mikethomas/fahview/viewer/files/xyz/package-info.java	0	0	1

Rules

Category	Rule	Violations	Severity
blocks	LeftCurly	1	Error
coding	HiddenField	1	Error
	MagicNumber	20	Error
design	DesignForExtension	3	Error
javadoc	JavadocPackage	1	Error
	JavadocStyle	5	Error
	JavadocVariable	6	Error
misc	FinalParameters	6	Error
sizes	LineLength	15	Error
whitespace	WhitespaceAround	1	Error

Details

info/mikethomas/fahview/viewer/JmolPanel.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocPackage	Missing package-info.java file.
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	41
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	42
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	43
Error	javadoc	JavadocStyle	First sentence should end with a period.	45
Error	javadoc	JavadocStyle	First sentence should end with a period.	52
Error	javadoc	JavadocStyle	First sentence should end with a period.	59
Error	design	DesignForExtension	Method 'getViewer' is not designed for extension - needs to be abstract, final or empty.	64
Error	blocks	LeftCurly	'{' at column 5 should be on the previous line.	65
Error	javadoc	JavadocStyle	First sentence should end with a period.	69
Error	design	DesignForExtension	Method 'paint' is not designed for extension - needs to be abstract, final or empty.	74
Error	misc	FinalParameters	Parameter g should be final.	75

info/mikethomas/fahview/viewer/files/xyz/XyzFileDataObject.java

Severity	Category	Rule	Message	Line
Error	coding	MagicNumber	'300' is a magic number.	53
Error	coding	MagicNumber	'300' is a magic number.	58
Error	sizes	LineLength	Line is longer than 80 characters (found 82).	63
Error	coding	MagicNumber	'100' is a magic number.	64
Error	coding	MagicNumber	'200' is a magic number.	65
Error	coding	MagicNumber	'300' is a magic number.	70
Error	coding	MagicNumber	'400' is a magic number.	75
Error	coding	MagicNumber	'500' is a magic number.	76
Error	sizes	LineLength	Line is longer than 80 characters (found 82).	80
Error	coding	MagicNumber	'600' is a magic number.	81
Error	sizes	LineLength	Line is longer than 80 characters (found 84).	85
Error	coding	MagicNumber	'700' is a magic number.	86
Error	coding	MagicNumber	'800' is a magic number.	87
Error	sizes	LineLength	Line is longer than 80 characters (found 92).	91
Error	coding	MagicNumber	'900' is a magic number.	92
Error	coding	MagicNumber	'1000' is a magic number.	93
Error	sizes	LineLength	Line is longer than 80 characters (found 88).	97
Error	coding	MagicNumber	'1100' is a magic number.	98
Error	coding	MagicNumber	'1200' is a magic number.	99
Error	sizes	LineLength	Line is longer than 80 characters (found 83).	103
Error	coding	MagicNumber	'1300' is a magic number.	104
Error	sizes	LineLength	Line is longer than 80 characters (found 88).	108
Error	coding	MagicNumber	'1400' is a magic number.	109
Error	sizes	LineLength	Line is longer than 80 characters (found 115).	121
Error	misc	FinalParameters	Parameter pf should be final.	121
Error	misc	FinalParameters	Parameter loader should be final.	121
Error	design	DesignForExtension	Method 'associateLookup' is not designed for extension - needs to be abstract, final or empty.	127
Error	sizes	LineLength	Line is longer than 80 characters (found 92).	136
Error	coding	MagicNumber	'1000' is a magic number.	144
Error	misc	FinalParameters	Parameter lkp should be final.	146

info/mikethomas/fahview/viewer/files/xyz/XyzFileVisualElement.java

Severity	Category	Rule	Message	Line
Error	coding	MagicNumber	'2000' is a magic number.	48
Error	sizes	LineLength	Line is longer than 80 characters (found 87).	50
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	52
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	53
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	54
Error	misc	FinalParameters	Parameter lkp should be final.	61
Error	sizes	LineLength	Line is longer than 80 characters (found 93).	78
Error	sizes	LineLength	Line is longer than 80 characters (found 81).	84
Error	coding	MagicNumber	'400' is a magic number.	85
Error	sizes	LineLength	Line is longer than 80 characters (found 81).	88
Error	coding	MagicNumber	'300' is a magic number.	89
Error	whitespace	WhitespaceAround	'}' is not followed by whitespace.	91
Error	sizes	LineLength	Line is longer than 80 characters (found 85).	124
Error	sizes	LineLength	Line is longer than 80 characters (found 89).	125
Error	misc	FinalParameters	Parameter callback should be final.	161
Error	coding	HiddenField	'callback' hides a field.	161

info/mikethomas/fahview/viewer/files/xyz/package-info.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocStyle	Missing a Javadoc comment.	2